This revision was automatically updated to reflect the committed changes.
Closed by commit rL361752: [ASTImporter] Added visibility context check for
CXXRecordDecl. (authored by balazske, committed by ).
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
balazske updated this revision to Diff 201133.
balazske added a comment.
- Changed type of string constants to const.
Repository:
rC Clang
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D62312/new/
https://reviews.llvm.org/D62312
Files:
lib/AST/ASTImporter.cpp
unittests/AST/ASTImp
balazske marked an inline comment as done.
balazske added a comment.
Thanks for reviewing.
Similar additions are planned to follow with function and variable template,
enum, scoped enum, typedef, type alias.
Comment at: unittests/AST/ASTImporterVisibilityTest.cpp:34
};
+stru
shafik accepted this revision.
shafik added a comment.
This revision is now accepted and ready to land.
LGTM
Repository:
rC Clang
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D62312/new/
https://reviews.llvm.org/D62312
___
cfe-commits ma
shafik added a comment.
Minor comments, I am going to run `check-lldb` now.
Comment at: unittests/AST/ASTImporterVisibilityTest.cpp:34
};
+struct GetClassPattern {
+ using DeclTy = CXXRecordDecl;
`GetCXXRecordPattern` feels more consistent.
balazske created this revision.
Herald added subscribers: cfe-commits, gamesh411, Szelethus, dkrupp.
Herald added a reviewer: martong.
Herald added a reviewer: a.sidorin.
Herald added a reviewer: shafik.
Herald added a project: clang.
ASTImporter makes now difference between classes with same name
