shafik added a comment.
Minor comments, I am going to run `check-lldb` now.
================
Comment at: unittests/AST/ASTImporterVisibilityTest.cpp:34
};
+struct GetClassPattern {
+ using DeclTy = CXXRecordDecl;
----------------
`GetCXXRecordPattern` feels more consistent.
================
Comment at: unittests/AST/ASTImporterVisibilityTest.cpp:49
+// CXXRecordDecl:
+auto *ExternC = "class X;";
+auto *AnonC = "namespace { class X; }";
----------------
`const`? It is not consistent w/ the previous declarations.
================
Comment at: unittests/AST/ASTImporterVisibilityTest.cpp:50
+auto *ExternC = "class X;";
+auto *AnonC = "namespace { class X; }";
----------------
`const`? It is not consistent w/ the previous declarations.
Repository:
rC Clang
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D62312/new/
https://reviews.llvm.org/D62312
_______________________________________________
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
