[PATCH] D62202: Work around a Visual C++ bug

This revision was automatically updated to reflect the committed changes. Closed by commit rL361502: Work around a Visual C++ bug. (authored by probinson, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D62

[PATCH] D62202: Work around a Visual C++ bug

dblaikie accepted this revision. dblaikie added a comment. This revision is now accepted and ready to land. SGTM - thanks! Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62202/new/ https://reviews.llvm.org/D62202 ___

[PATCH] D62202: Work around a Visual C++ bug

probinson added a comment. // FIXME: Change the following functions from anonymous namespace to static // after the minimum _MSC_VER >= 1915 (equivalent to Visual Studio version // of 15.8 or higher). Works around a bug in earlier versions. ? Also happy to include the hyperlink to the bug

[PATCH] D62202: Work around a Visual C++ bug

dblaikie added a comment. In D62202#1510835 , @rnk wrote: > In D62202#1510522 , @dblaikie wrote: > > > Yeah, if we're going this way I'd certainly advocate having a comment of > > some kind explaining why it's this

[PATCH] D62202: Work around a Visual C++ bug

rnk added a comment. In D62202#1510522 , @dblaikie wrote: > Yeah, if we're going this way I'd certainly advocate having a comment of some > kind explaining why it's this way so it doesn't regress. In the past, I've found these sorts of comments to be pr

[PATCH] D62202: Work around a Visual C++ bug

rnk added a comment. I'd go ahead and commit the workaround, even if it goes against the style guide. This problem will go away in two years or so. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62202/new/ https://reviews.llvm.org/D62202 __

[PATCH] D62202: Work around a Visual C++ bug

probinson added a comment. The helper is passed as a template parameter to a class ctor, and that instantiated class calls the helper from operator(), so I suppose maybe enough indirection through lambdas but this seems kind of involved for getting my builds to work. Repository: rC Clang

[PATCH] D62202: Work around a Visual C++ bug

dblaikie added a comment. In D62202#1510449 , @probinson wrote: > In D62202#1510414 , @dblaikie wrote: > > > Technically this violates the LLVM style guide which says "make anonymous > > namespaces as small as poss

[PATCH] D62202: Work around a Visual C++ bug

probinson added a comment. In D62202#1510414 , @dblaikie wrote: > Technically this violates the LLVM style guide which says "make anonymous > namespaces as small as possible, and only use them for class declarations." > (preferring static for functions)

[PATCH] D62202: Work around a Visual C++ bug

dblaikie added a comment. In D62202#1510394 , @probinson wrote: > To provide some missing details: > The original source gets a bogus compile-time error with Visual Studio 2017, > prior to version 15.8. I have 15.2, so I need this patch to build Clang.

[PATCH] D62202: Work around a Visual C++ bug

probinson added a comment. To provide some missing details: The original source gets a bogus compile-time error with Visual Studio 2017, prior to version 15.8. I have 15.2, so I need this patch to build Clang. Our current minimum-version requirement (per CheckCompilerVersion.cmake) is Visual St

[PATCH] D62202: Work around a Visual C++ bug

probinson created this revision. probinson added reviewers: aaron.ballman, rnk. Herald added a project: clang. Herald added a subscriber: cfe-commits. Put up for review because I'm not clear whether this should be considered a permanent fix, or if I should put some sort of comment here indicating