dblaikie added a comment. In D62202#1510835 <https://reviews.llvm.org/D62202#1510835>, @rnk wrote:
> In D62202#1510522 <https://reviews.llvm.org/D62202#1510522>, @dblaikie wrote: > > > Yeah, if we're going this way I'd certainly advocate having a comment of > > some kind explaining why it's this way so it doesn't regress. > > > In the past, I've found these sorts of comments to be pretty low value. They > don't do anything to help the reader understand what the code is trying to > do. If we want this thing to not regress, someone who cares can set up a > buildbot for it. I think it's more likely that by the time somebody does this > again, Paul and other users of Visual C++ will have upgraded to 14.8. Or, > they'll send another one of these changes. Then a comment might help explain that the workaround can be removed at that point. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62202/new/ https://reviews.llvm.org/D62202 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
