[PATCH] D61601: [clangd] Represent Hover result using FormattedString

This revision was automatically updated to reflect the committed changes. Closed by commit rL361940: [clangd] Represent Hover result using FormattedString (authored by ibiryukov, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: http

[PATCH] D61601: [clangd] Represent Hover result using FormattedString

ilya-biryukov added inline comments. Comment at: clang-tools-extra/clangd/XRefs.cpp:1170 else if (NamespaceScope->empty()) - Out << "global namespace"; + Output.appendText(" global namespace"); else kadircet wrote: > Should this also be `inlin

[PATCH] D61601: [clangd] Represent Hover result using FormattedString

ilya-biryukov updated this revision to Diff 201847. ilya-biryukov marked 2 inline comments as done. ilya-biryukov added a comment. - Create an inline code block for 'global namespace' too Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61601/new/ htt

[PATCH] D61601: [clangd] Represent Hover result using FormattedString

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. LGTM, thanks! Comment at: clang-tools-extra/clangd/XRefs.cpp:1170 else if (NamespaceScope->empty()) - Out << "global namespace"; + Output.appendText(" glob

[PATCH] D61601: [clangd] Represent Hover result using FormattedString

ilya-biryukov added a comment. This is ready for review now Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61601/new/ https://reviews.llvm.org/D61601 ___ cfe-commits mailing list cfe-commits@lists.llvm.

[PATCH] D61601: [clangd] Represent Hover result using FormattedString

ilya-biryukov updated this revision to Diff 201844. ilya-biryukov added a comment. - Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61601/new/ https://reviews.llvm.org/D61601 Files: clang-tools-extra/clangd/ClangdLSPServer.cpp clang-tool

[PATCH] D61601: [clangd] Represent Hover result using FormattedString

kadircet added a comment. Ping, D61497 has landed Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61601/new/ https://reviews.llvm.org/D61601 ___ cfe-commits mailing list

[PATCH] D61601: [clangd] Represent Hover result using FormattedString

ilya-biryukov planned changes to this revision. ilya-biryukov added a comment. Planning to rebase this on top of D61497 and land afterwards in order to minimize merge conflicts. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.

[PATCH] D61601: [clangd] Represent Hover result using FormattedString

ilya-biryukov updated this revision to Diff 198415. ilya-biryukov marked an inline comment as done. ilya-biryukov added a comment. - Forgotten change Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61601/new/ https://reviews.llvm.org/D61601 Files:

[PATCH] D61601: [clangd] Represent Hover result using FormattedString

ilya-biryukov added inline comments. Comment at: clang-tools-extra/clangd/Protocol.cpp:707 + else +return false; + return true; kadircet wrote: > kadircet wrote: > > Maybe also vlog/elog the unknown kind? So that we can easily catch new > > additions to sp

[PATCH] D61601: [clangd] Represent Hover result using FormattedString

kadircet added a comment. > I'm happy to restructure the `HoverInfo` to your liking if the current one > seems problematic for any reason. It will just cause more code move on my side, no problems apart from that Comment at: clang-tools-extra/clangd/Protocol.cpp:707 + else +

[PATCH] D61601: [clangd] Represent Hover result using FormattedString

ilya-biryukov marked 3 inline comments as done. ilya-biryukov added inline comments. Comment at: clang-tools-extra/clangd/ClangdLSPServer.cpp:853 + Hover R; + switch (HoverContentFormat) { + case MarkupKin

[PATCH] D61601: [clangd] Represent Hover result using FormattedString

ilya-biryukov updated this revision to Diff 198410. ilya-biryukov added a comment. - Move range and kind assignment out of the loop. - Log error on failed deserialization of markup kind. - s/Plaintext/PlainText Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.ll

[PATCH] D61601: [clangd] Represent Hover result using FormattedString

ilya-biryukov added a comment. In D61601#1492979 , @kadircet wrote: > I think it makes more sense to expose semantical information in > HoverInfo(like Name, Scope, Definition, etc), rather than formatted strings, > and let this be serialized by the users

[PATCH] D61601: [clangd] Represent Hover result using FormattedString

kadircet added a comment. I think it makes more sense to expose semantical information in HoverInfo(like Name, Scope, Definition, etc), rather than formatted strings, and let this be serialized by the users of ClangdServer (as in D61497 ). This is what I'll perf

[PATCH] D61601: [clangd] Represent Hover result using FormattedString

ilya-biryukov created this revision. ilya-biryukov added a reviewer: sammccall. Herald added subscribers: kadircet, arphaman, jkorous, MaskRay. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D61601 Files: clang-tools-extra/clangd/ClangdLSPServer.c