sammccall added a comment.
Incidentally, this was not NFC - it deduplicates edits and therefore works
around a bug in the visitor!
Repository:
rCTE Clang Tools Extra
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D61596/new/
https://reviews.llvm.org/D61596
_
sammccall marked 2 inline comments as done.
sammccall added inline comments.
Comment at: clangd/ClangdServer.cpp:264
Callback> CB) {
- auto Action = [Pos](Path File, std::string NewName,
+ auto Action = [Pos](std::string File, std::string NewName,
This revision was automatically updated to reflect the committed changes.
sammccall marked an inline comment as done.
Closed by commit rCTE360116: [clangd] Move Rename into its own file, and add
unit test. NFC (authored by sammccall, committed by ).
Changed prior to commit:
https://reviews.llvm
kadircet accepted this revision.
kadircet added a comment.
This revision is now accepted and ready to land.
LGTM
Comment at: clangd/ClangdServer.cpp:264
Callback> CB) {
- auto Action = [Pos](Path File, std::string NewName,
+ auto Action = [Pos](std:
sammccall created this revision.
sammccall added a reviewer: kadircet.
Herald added subscribers: cfe-commits, jfb, arphaman, jkorous, MaskRay,
ilya-biryukov, mgorny.
Herald added a project: clang.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D61596
Files:
clangd/CMakeLists.tx
