[PATCH] D61112: AMDGPU: Enable _Float16

yaxunl marked an inline comment as done. yaxunl added a comment. In D61112#2584279 , @foad wrote: > Should have updated > https://clang.llvm.org/docs/LanguageExtensions.html#half-precision-floating-point > "_Float16 is currently only supported on the fol

[PATCH] D61112: AMDGPU: Enable _Float16

arsenm added inline comments. Comment at: test/CodeGenCXX/amdgpu-float16.cpp:7 + _Float16 x, y, z; + // CHECK: v_add_f16_e64 + // NOF16: v_add_f32_e64 I thought clang tests were supposed to stop at the IR CHANGES SINCE LAST ACTION https://reviews.llvm.org/

[PATCH] D61112: AMDGPU: Enable _Float16

foad added a comment. Herald added a subscriber: kerbowa. Should have updated https://clang.llvm.org/docs/LanguageExtensions.html#half-precision-floating-point "_Float16 is currently only supported on the following targets, with further targets pending ABI standardization: ..." CHANGES SINCE

[PATCH] D61112: AMDGPU: Enable _Float16

rampitec accepted this revision. rampitec added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61112/new/ https://reviews.llvm.org/D61112 ___ cfe-commits mailing list cfe-commi

[PATCH] D61112: AMDGPU: Enable _Float16

b-sumner added a comment. Looks good to me. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61112/new/ https://reviews.llvm.org/D61112 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe

[PATCH] D61112: AMDGPU: Enable _Float16

yaxunl created this revision. yaxunl added reviewers: b-sumner, rampitec, arsenm. Herald added subscribers: t-tye, tpr, dstuttard, nhaehnle, wdng, jvesely, kzhuravl. https://reviews.llvm.org/D61112 Files: lib/Basic/Targets/AMDGPU.cpp test/CodeGenCXX/amdgpu-float16.cpp Index: test/CodeGenCX