[PATCH] D60029: Add const children() accessors to Stmts

2019-03-30 Thread Bruno Ricci via Phabricator via cfe-commits
riccibruno added a comment. In D60029#1448944 , @nicolas wrote: > In D60029#1448938 , @riccibruno > wrote: > > > Did you go over all the statements on `Stmt.h` systematically ? > > > Yes. > > > You could also do th

[PATCH] D60029: Add const children() accessors to Stmts

2019-03-30 Thread Nicolas Manichon via Phabricator via cfe-commits
nicolas added a comment. In D60029#1448938 , @riccibruno wrote: > Did you go over all the statements on `Stmt.h` systematically ? Yes. > You could also do the same thing for all of the statements/expressions in > `StmtCXX.h`, `Expr.h`, `ExprCXX.h`, and

[PATCH] D60029: Add const children() accessors to Stmts

2019-03-30 Thread Bruno Ricci via Phabricator via cfe-commits
riccibruno added a comment. +1. I wanted to do this but never bothered. Did you go over all the statements on `Stmt.h` systematically ? You could also do the same thing for all of the statements/expressions in `StmtCXX.h`, `Expr.h`, `ExprCXX.h`, and so on. Apart from this did you run `clang-for

[PATCH] D60029: Add const children() accessors to Stmts

2019-03-30 Thread Nicolas Manichon via Phabricator via cfe-commits
nicolas created this revision. nicolas added reviewers: bkramer, rsmith. nicolas added a project: clang. Herald added a subscriber: cfe-commits. Exprs already have children() const but not Stmts. All the changes are very simple, except for `DeclStmt` where I used a `const_cast`. Repository: r