This revision was automatically updated to reflect the committed changes.
Closed by commit rL356452: [ASTImporter] Fix redecl failures of
ClassTemplateSpec (authored by martong, committed by ).
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https
shafik accepted this revision.
shafik added a comment.
LGTM
Repository:
rC Clang
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D58673/new/
https://reviews.llvm.org/D58673
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lis
martong marked an inline comment as done.
martong added a comment.
@shafik Ping
Repository:
rC Clang
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D58673/new/
https://reviews.llvm.org/D58673
___
cfe-commits mailing list
cfe-commits@lists.
martong marked 2 inline comments as done.
martong added inline comments.
Comment at: lib/AST/ASTImporter.cpp:5147
}
+} else { // ODR violation.
+ // FIXME HandleNameConflict
shafik wrote:
> ODR violations are ill-formed no diagnostic required. So
shafik added inline comments.
Comment at: lib/AST/ASTImporter.cpp:5147
}
+} else { // ODR violation.
+ // FIXME HandleNameConflict
ODR violations are ill-formed no diagnostic required. So currently will this
fail for cases that clang proper would
martong added a comment.
Alexei, thanks for the review!
Repository:
rC Clang
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D58673/new/
https://reviews.llvm.org/D58673
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.l
martong updated this revision to Diff 189131.
martong marked 2 inline comments as done.
martong added a comment.
- Fix some comments
Repository:
rC Clang
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D58673/new/
https://reviews.llvm.org/D58673
Files:
lib/AST/ASTImporter.cpp
unitt
a_sidorin accepted this revision.
a_sidorin added a comment.
This revision is now accepted and ready to land.
Hi Gabor,
Thanks for the patch! It looks good to me except some stylish nits.
Comment at: lib/AST/ASTImporter.cpp:5130
+Importer.MapImported(D, PrevDecl->getDef
martong created this revision.
martong added reviewers: a_sidorin, shafik.
Herald added subscribers: cfe-commits, jdoerfert, gamesh411, Szelethus, dkrupp,
rnkovacs.
Herald added a reviewer: a.sidorin.
Herald added a project: clang.
Redecl chains of class template specializations are not handled w
