a_sidorin accepted this revision. a_sidorin added a comment. This revision is now accepted and ready to land.
Hi Gabor, Thanks for the patch! It looks good to me except some stylish nits. ================ Comment at: lib/AST/ASTImporter.cpp:5130 + Importer.MapImported(D, PrevDecl->getDefinition()); + // Import those those default field initializers which have been + // instantiated in the "From" context, but not in the "To" context. ---------------- Could you please also replace "those those" to "those" in the comment below? ================ Comment at: lib/AST/ASTImporter.cpp:5144 + // Generally, ASTCommon.h/DeclUpdateKind enum gives a very good hint + // what + // else could be fused during an AST merge. ---------------- The comment is a bit broken. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58673/new/ https://reviews.llvm.org/D58673 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
