[PATCH] D58666: [OpenCL] Undefine cl_intel_planar_yuv extension

This revision was automatically updated to reflect the committed changes. Closed by commit rL362398: [OpenCL] Undefine cl_intel_planar_yuv extension (authored by asavonic, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://rev

[PATCH] D58666: [OpenCL] Undefine cl_intel_planar_yuv extension

Anastasia accepted this revision. Anastasia added a comment. This revision is now accepted and ready to land. LGTM! I am ok with this change to remove the macro from the common header. I don't think it belongs to there. However, I believe this functionality should be better represented in the ve

[PATCH] D58666: [OpenCL] Undefine cl_intel_planar_yuv extension

sidorovd marked an inline comment as done. sidorovd added inline comments. Comment at: test/SemaOpenCL/extension-begin.cl:26 + #ifndef IMPLICIT_INCLUDE #include "extension-begin.h" Anastasia wrote: > sidorovd wrote: > > Anastasia wrote: > > > sidorovd wrote: >

[PATCH] D58666: [OpenCL] Undefine cl_intel_planar_yuv extension

Anastasia added inline comments. Comment at: test/SemaOpenCL/extension-begin.cl:26 + #ifndef IMPLICIT_INCLUDE #include "extension-begin.h" sidorovd wrote: > Anastasia wrote: > > sidorovd wrote: > > > Anastasia wrote: > > > > Can we also test that macro `my_ext`

[PATCH] D58666: [OpenCL] Undefine cl_intel_planar_yuv extension

sidorovd marked an inline comment as done. sidorovd added inline comments. Comment at: test/SemaOpenCL/extension-begin.cl:26 + #ifndef IMPLICIT_INCLUDE #include "extension-begin.h" Anastasia wrote: > sidorovd wrote: > > Anastasia wrote: > > > Can we also test t

[PATCH] D58666: [OpenCL] Undefine cl_intel_planar_yuv extension

Anastasia added inline comments. Comment at: test/SemaOpenCL/extension-begin.cl:26 + #ifndef IMPLICIT_INCLUDE #include "extension-begin.h" sidorovd wrote: > Anastasia wrote: > > Can we also test that macro `my_ext` is not defined here but defined above? > > >

[PATCH] D58666: [OpenCL] Undefine cl_intel_planar_yuv extension

sidorovd marked an inline comment as done. sidorovd added inline comments. Comment at: test/SemaOpenCL/extension-begin.cl:26 + #ifndef IMPLICIT_INCLUDE #include "extension-begin.h" Anastasia wrote: > Can we also test that macro `my_ext` is not defined here but

[PATCH] D58666: [OpenCL] Undefine cl_intel_planar_yuv extension

Anastasia added inline comments. Comment at: test/SemaOpenCL/extension-begin.cl:26 + #ifndef IMPLICIT_INCLUDE #include "extension-begin.h" Can we also test that macro `my_ext` is not defined here but defined above? It seems we are not testing anything like thi

[PATCH] D58666: [OpenCL] Undefine cl_intel_planar_yuv extension

sidorovd updated this revision to Diff 188338. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58666/new/ https://reviews.llvm.org/D58666 Files: lib/Headers/opencl-c.h test/Headers/opencl-c-header.cl test/SemaOpenCL/extension-begin.cl Index: test/SemaOpenCL/extension-begin.cl =

[PATCH] D58666: [OpenCL] Undefine cl_intel_planar_yuv extension

sidorovd created this revision. sidorovd added reviewers: Anastasia, yaxunl. Herald added a project: clang. Herald added a subscriber: cfe-commits. Consider the code: #pragma OPENCL EXTENSION cl_intel_planar_yuv : begin // some declarations #pragma OPENCL EXTENSION cl_intel_planar_yuv : end