sidorovd marked an inline comment as done.
sidorovd added inline comments.

================
Comment at: test/SemaOpenCL/extension-begin.cl:26
+
 #ifndef IMPLICIT_INCLUDE
 #include "extension-begin.h"
----------------
Anastasia wrote:
> Can we also test that macro `my_ext` is not defined here but defined above?
> 
> It seems we are not testing anything like this...
#pragma OPENCL EXTENSION my_ext : begin doesn't define an appropriate macro. 
And so cl-ext=+my_ext.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58666/new/

https://reviews.llvm.org/D58666



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to