[PATCH] D58340: [clang][Index] Visit UsingDecls and generate USRs for them

This revision was automatically updated to reflect the committed changes. Closed by commit rL354878: [clang][Index] Visit UsingDecls and generate USRs for them (authored by kadircet, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Repository: rL LLVM CHAN

[PATCH] D58340: [clang][Index] Visit UsingDecls and generate USRs for them

kadircet updated this revision to Diff 188361. kadircet marked an inline comment as done. kadircet added a comment. - Revert SymbolSubKind change - Add test to check for SymbolKind Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58340/new/ https://reviews.llvm.org/

[PATCH] D58340: [clang][Index] Visit UsingDecls and generate USRs for them

ilya-biryukov added inline comments. Comment at: include/clang/Index/IndexSymbol.h:75 UsingValue, + UsingDeclaration, }; We don't seem to use the subkind anywhere. Let's remove it. Comment at: unittests/Index/IndexTests.cpp:253 + tooling:

[PATCH] D58340: [clang][Index] Visit UsingDecls and generate USRs for them

kadircet updated this revision to Diff 188171. kadircet added a comment. - Add SymbolSubKind for UsingDeclarations Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58340/new/ https://reviews.llvm.org/D58340 Files: include/clang/Index/IndexSymbol.h lib/Index/Ind

[PATCH] D58340: [clang][Index] Visit UsingDecls and generate USRs for them

kadircet updated this revision to Diff 187236. kadircet added a comment. - Address comments Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58340/new/ https://reviews.llvm.org/D58340 Files: lib/Index/IndexDecl.cpp lib/Index/USRGeneration.cpp test/Index/usrs.

[PATCH] D58340: [clang][Index] Visit UsingDecls and generate USRs for them

ilya-biryukov accepted this revision. ilya-biryukov added a comment. This revision is now accepted and ready to land. LGTM, but we need to make sure the variable is used in configs without assertions, otherwise we'll break buildbots. Repository: rC Clang CHANGES SINCE LAST ACTION https://r

[PATCH] D58340: [clang][Index] Visit UsingDecls and generate USRs for them

ilya-biryukov added inline comments. Comment at: lib/Index/IndexDecl.cpp:586 +IndexCtx.handleDecl(D); IndexCtx.indexNestedNameSpecifierLoc(D->getQualifierLoc(), Parent, NIT: maybe put it at the very first line of the function, before the `DC` and `Par

[PATCH] D58340: [clang][Index] Visit UsingDecls and generate USRs for them

kadircet updated this revision to Diff 187208. kadircet marked 3 inline comments as done. kadircet added a comment. - Address comments Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58340/new/ https://reviews.llvm.org/D58340 Files: lib/Index/IndexDecl.cpp lib

[PATCH] D58340: [clang][Index] Visit UsingDecls and generate USRs for them

ilya-biryukov added inline comments. Comment at: lib/Index/IndexDecl.cpp:588 D->getLexicalDeclContext()); +IndexCtx.handleDecl(D); for (const auto *I : D->shadows()) Any reason to add this to the middle of the fu

[PATCH] D58340: [clang][Index] Visit UsingDecls and generate USRs for them

kadircet created this revision. kadircet added reviewers: ilya-biryukov, akyrtzi. Herald added subscribers: cfe-commits, arphaman. Herald added a project: clang. Add indexing of UsingDecl itself. Also enable generation of USRs for UsingDecls, using the qualified name of the decl. Repository: r