ilya-biryukov added inline comments.
================ Comment at: include/clang/Index/IndexSymbol.h:75 UsingValue, + UsingDeclaration, }; ---------------- We don't seem to use the subkind anywhere. Let's remove it. ================ Comment at: unittests/Index/IndexTests.cpp:253 + tooling::runToolOnCode(new IndexAction(Index, Opts), Code); + EXPECT_THAT(Index->Symbols, Contains(QName("std::foo"))); +} ---------------- Could we also test the kind is correct here? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58340/new/ https://reviews.llvm.org/D58340 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits