[PATCH] D58213: [FileManager] fillRealPathName even if we aren't opening the file

This revision was automatically updated to reflect the committed changes. jkorous marked an inline comment as done. Closed by commit rC354075: [clang][FileManager] fillRealPathName even if we aren't opening the file (authored by jkorous, committed by ). Repository: rC Clang CHANGES SINCE LAST

[PATCH] D58213: [FileManager] fillRealPathName even if we aren't opening the file

arphaman accepted this revision. arphaman added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58213/new/ https://reviews.llvm.org/D58213 ___ cfe-commits mailing list cfe-commi

[PATCH] D58213: [FileManager] fillRealPathName even if we aren't opening the file

jkorous marked 4 inline comments as done. jkorous added a comment. Updated the patch. Comment at: unittests/Basic/FileManagerTest.cpp:349 +// rdar://problem/47536127 +TEST_F(FileManagerTest, getFileDontOpenRealPath) { arphaman wrote: > jkorous wrote: > > arph

[PATCH] D58213: [FileManager] fillRealPathName even if we aren't opening the file

jkorous updated this revision to Diff 186906. jkorous added a comment. - comments - explicit openFile = false in test CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58213/new/ https://reviews.llvm.org/D58213 Files: lib/Basic/FileManager.cpp unittests/Basic/FileManagerTest.cpp Inde

[PATCH] D58213: [FileManager] fillRealPathName even if we aren't opening the file

arphaman added inline comments. Comment at: unittests/Basic/FileManagerTest.cpp:349 +// rdar://problem/47536127 +TEST_F(FileManagerTest, getFileDontOpenRealPath) { jkorous wrote: > arphaman wrote: > > Please leave this comment out > Sure, no problem. > > Just

[PATCH] D58213: [FileManager] fillRealPathName even if we aren't opening the file

arphaman added inline comments. Comment at: lib/Basic/FileManager.cpp:271 + } else if (!openFile) { +// Since we didn't return early after getStatValue() call the file exists. +fillRealPathName(&UFE, InterndFileName); jkorous wrote: > arphaman wrote: > >

[PATCH] D58213: [FileManager] fillRealPathName even if we aren't opening the file

jkorous marked an inline comment as done. jkorous added inline comments. Comment at: unittests/Basic/FileManagerTest.cpp:349 +// rdar://problem/47536127 +TEST_F(FileManagerTest, getFileDontOpenRealPath) { arphaman wrote: > Please leave this comment out Sure, no

[PATCH] D58213: [FileManager] fillRealPathName even if we aren't opening the file

jkorous marked 2 inline comments as done. jkorous added a comment. Thanks for taking a look! Comment at: lib/Basic/FileManager.cpp:214 return nullptr; } If we can't stat the file we return here. Comment at: lib/Basic/FileManager.cpp

[PATCH] D58213: [FileManager] fillRealPathName even if we aren't opening the file

arphaman added inline comments. Comment at: lib/Basic/FileManager.cpp:271 + } else if (!openFile) { +// Since we didn't return early after getStatValue() call the file exists. +fillRealPathName(&UFE, InterndFileName); I don't really understand what this

[PATCH] D58213: [FileManager] fillRealPathName even if we aren't opening the file

jkorous added a comment. @sammccall I think you touched this part of the code recently in r352079 (revert of r347205). Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58213/new/ https://reviews.llvm.org/D58213 ___ cfe

[PATCH] D58213: [FileManager] fillRealPathName even if we aren't opening the file

jkorous created this revision. jkorous added reviewers: sammccall, arphaman. Herald added subscribers: cfe-commits, kadircet, dexonsmith, ioeric, ilya-biryukov. Herald added a project: clang. This fixes an internal test failure in clangd - ClangdTests.GoToInclude.All rdar://47536127 Repository