arphaman added inline comments.
================
Comment at: lib/Basic/FileManager.cpp:271
+ } else if (!openFile) {
+ // Since we didn't return early after getStatValue() call the file exists.
+ fillRealPathName(&UFE, InterndFileName);
----------------
jkorous wrote:
> arphaman wrote:
> > I don't really understand what this comment is trying to say. Can you
> > rephrase it?
> Please see the above comment (line 214).
>
> What I meant is that it's guaranteed that the file exists as we would have
> returned otherwise. Does that make sense?
>
> Any suggestion how to rephrase the comment? (Or shall I just remove it?)
The throwback here is unnecessary. You can just say that RealFilePath should
still be filled even for `stat`s.
================
Comment at: unittests/Basic/FileManagerTest.cpp:357
+
+ const FileEntry *file = manager.getFile(Path);
+
----------------
NIT: You might want to make `OpenFile = false` explicit to emphasize the stat.
Repository:
rC Clang
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D58213/new/
https://reviews.llvm.org/D58213
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
