[PATCH] D58072: Make ModuleDependencyCollector's method virtual (NFC)

This revision was automatically updated to reflect the committed changes. Closed by commit rL353882: Make ModuleDependencyCollector's method virtual (NFC) (authored by JDevlieghere, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: h

[PATCH] D58072: Make ModuleDependencyCollector's method virtual (NFC)

bruno accepted this revision. bruno added a comment. This revision is now accepted and ready to land. LGTM! Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58072/new/ https://reviews.llvm.org/D58072 ___ cfe-commits mai

[PATCH] D58072: Make ModuleDependencyCollector's method virtual (NFC)

JDevlieghere added a comment. Alright, I'll split this up in two patches Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58072/new/ https://reviews.llvm.org/D58072 ___ cfe-commits mailing list cfe-commits@lists.llvm.or

[PATCH] D58072: Make ModuleDependencyCollector's method virtual (NFC)

bruno added a comment. I missed that the `DependencyCollector` already marks them virtual, you are just making it obvious here. I think you can omit the ones that are already virtual and only add to the ones that are on the intend of this patch. Repository: rC Clang CHANGES SINCE LAST ACTI

[PATCH] D58072: Make ModuleDependencyCollector's method virtual (NFC)

JDevlieghere added a comment. In D58072#1393817 , @bruno wrote: > Not really. Would making only the `attachTo*` methods virtual enough though? You mean making them **not** virtual? They're the only ones I don't override. Repository: rC Clang CHANGES

[PATCH] D58072: Make ModuleDependencyCollector's method virtual (NFC)

bruno added a comment. Not really. Would making only the `attachTo*` methods virtual enough though? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58072/new/ https://reviews.llvm.org/D58072 ___ cfe-commits mailing lis

[PATCH] D58072: Make ModuleDependencyCollector's method virtual (NFC)

JDevlieghere added a comment. In D58072#1393640 , @bruno wrote: > How much of the `ModuleDependencyCollector` will be reused as is by LLDB? I > wonder about the tradeoff versus inheriting from `DependencyCollector` > directly. We reuse the `attachTo` m

[PATCH] D58072: Make ModuleDependencyCollector's method virtual (NFC)

bruno added a comment. How much of the `ModuleDependencyCollector` will be reused as is by LLDB? I wonder about the tradeoff versus inheriting from `DependencyCollector` directly. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58072/new/ https://reviews.llvm.org/

[PATCH] D58072: Make ModuleDependencyCollector's method virtual (NFC)

JDevlieghere created this revision. JDevlieghere added reviewers: bruno, vsapsai. Herald added a project: clang. For reproducers in LLDB we want to hook up into the existing clang infrastructure. To make that happen we need to be able to override the ModuleDependencyCollector's methods. Reposi