JDevlieghere added a comment.

In D58072#1393640 <https://reviews.llvm.org/D58072#1393640>, @bruno wrote:

> How much of the `ModuleDependencyCollector` will be reused as is by LLDB? I 
> wonder about the tradeoff versus inheriting from `DependencyCollector` 
> directly.


We reuse the `attachTo` methods, which in turn use the 
`ModuleDependencyListener`, `ModuleDependencyPPCallbacks` and 
`ModuleDependencyMMCallbacks`. Do you think it's worth re-implementing those?


Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58072/new/

https://reviews.llvm.org/D58072



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to