[PATCH] D57435: [clang-tidy] Add abseil-wrap-unique check

Dosi-Dough added a comment. Gentle ping Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57435/new/ https://reviews.llvm.org/D57435 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llv

[PATCH] D57435: [clang-tidy] Add abseil-wrap-unique check

Dosi-Dough added a comment. gentle ping Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57435/new/ https://reviews.llvm.org/D57435 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llv

[PATCH] D57435: [clang-tidy] Add abseil-wrap-unique check

Dosi-Dough added a comment. @EricWF @JonasToth I was wondering what other changes I should make to submit my check upstream? Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57435/new/ https://reviews.llvm.org/D57435 ___

[PATCH] D57435: [clang-tidy] Add abseil-wrap-unique check

Dosi-Dough added a comment. Hi I was wondering if there were any other changes anyone recomends should be made to this revision? Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57435/new/ https://reviews.llvm.org/D57435 ___

[PATCH] D57435: [clang-tidy] Add abseil-wrap-unique check

Dosi-Dough updated this revision to Diff 194622. Dosi-Dough added a comment. added white space to check doc. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57435/new/ https://reviews.llvm.org/D57435 Files: clang-tidy/abseil/AbseilTidyModule.cpp

[PATCH] D57435: [clang-tidy] Add abseil-wrap-unique check

Dosi-Dough updated this revision to Diff 194621. Dosi-Dough marked 2 inline comments as done. Dosi-Dough added a comment. added whitespace to check doc Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57435/new/ https://reviews.llvm.org/D57435 Files:

[PATCH] D57435: [clang-tidy] Add abseil-wrap-unique check

Eugene.Zelenko added inline comments. Comment at: docs/clang-tidy/checks/abseil-wrap-unique.rst:5 +== +Looks for instances of factory functions which uses a non-public constructor +that returns a ``std::unqiue_ptr`` then recommends using ``absl::wrap_unique(new

[PATCH] D57435: [clang-tidy] Add abseil-wrap-unique check

Dosi-Dough updated this revision to Diff 194618. Dosi-Dough marked 3 inline comments as done. Dosi-Dough added a comment. removed parens from turnary, added whitespace. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57435/new/ https://reviews.llvm.or

[PATCH] D57435: [clang-tidy] Add abseil-wrap-unique check

Eugene.Zelenko added inline comments. Comment at: clang-tidy/abseil/WrapUniqueCheck.cpp:85 + +std::string Left = (ConsDecl) ? "auto " + NameRef.str() + " = " : ""; +std::string NewText = I don't think that you need round brackets around ConsDecl. Same bel

[PATCH] D57435: [clang-tidy] Add abseil-wrap-unique check

Dosi-Dough updated this revision to Diff 194608. Dosi-Dough added a comment. fixed docs and white spacing Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57435/new/ https://reviews.llvm.org/D57435 Files: clang-tidy/abseil/AbseilTidyModule.cpp cla

[PATCH] D57435: [clang-tidy] Add abseil-wrap-unique check

Dosi-Dough updated this revision to Diff 194607. Dosi-Dough marked an inline comment as done. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57435/new/ https://reviews.llvm.org/D57435 Files: clang-tidy/abseil/AbseilTidyModule.cpp clang-tidy/abseil

[PATCH] D57435: [clang-tidy] Add abseil-wrap-unique check

Dosi-Dough updated this revision to Diff 193421. Dosi-Dough marked 2 inline comments as done. Dosi-Dough added a comment. added minor style changes and removed unnecessary inline comments. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57435/new/ htt

[PATCH] D57435: [clang-tidy] Add abseil-wrap-unique check

Eugene.Zelenko added inline comments. Comment at: clang-tidy/abseil/WrapUniqueCheck.h:26 +private: + // std::string getArgs(const SourceManager *SM, const CallExpr *MemExpr); + Please remove obsolete commend and private keyword. Comment at: doc

[PATCH] D57435: [clang-tidy] Add abseil-wrap-unique check

Dosi-Dough updated this revision to Diff 192541. Dosi-Dough marked 4 inline comments as done. Dosi-Dough added a comment. fixed bracketed return and added updated license CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57435/new/ https://reviews.llvm.org/D57435 Files: clang-tidy/abseil

[PATCH] D57435: [clang-tidy] Add abseil-wrap-unique check

MyDeveloperDay added inline comments. Comment at: clang-tidy/abseil/WrapUniqueCheck.cpp:7 +// License. See LICENSE.TXT for details. +// +//===--===// License as above Comment a

[PATCH] D57435: [clang-tidy] Add abseil-wrap-unique check

Dosi-Dough updated this revision to Diff 190552. Dosi-Dough marked 11 inline comments as done. Dosi-Dough added a comment. Herald added a subscriber: jdoerfert. Herald added a project: clang. added style and performance refactoring based on code reviews Repository: rCTE Clang Tools Extra CHAN

[PATCH] D57435: [clang-tidy] Add abseil-wrap-unique check

MyDeveloperDay added a comment. This is the clang-tidy revision that mgiht have caught the str().length() > 0 case D56644: [clang-tidy] readability-container-size-empty handle std::string length() adding a a cross reference for that work. Repository: rCTE

[PATCH] D57435: [clang-tidy] Add abseil-wrap-unique check

MyDeveloperDay added inline comments. Comment at: clang-tidy/abseil/WrapUniqueCheck.h:27 +private: + std::string getArgs(const SourceManager *SM, const CallExpr *MemExpr); + Nit: could this method could be static in the cpp file and not in the header? Reposito

[PATCH] D57435: [clang-tidy] Add abseil-wrap-unique check

MyDeveloperDay added inline comments. Comment at: clang-tidy/abseil/WrapUniqueCheck.cpp:54 + const auto *facExpr = Result.Nodes.getNodeAs("facCons"); + const auto *callExpr = Result.Nodes.getNodeAs("callExpr"); + I'm not sure how expensive getNodeAs is... or if

[PATCH] D57435: [clang-tidy] Add abseil-wrap-unique check

MyDeveloperDay added inline comments. Comment at: clang-tidy/abseil/WrapUniqueCheck.cpp:27 + + return (ArgRef.str().length() > 0) ? ArgRef.str() + ")" : "()"; +} couldn't this be ``` return (!ArgRef.empty()) ? ArgRef.str() + ")" : "()"; ``` You know I think t

[PATCH] D57435: [clang-tidy] Add abseil-wrap-unique check

Dosi-Dough updated this revision to Diff 184437. Dosi-Dough added a comment. based on feedback: fixed whitespacing / formatting. Removed .DS_Store Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57435/new/ https://reviews.llvm.org/D57435 Files: c

[PATCH] D57435: [clang-tidy] Add abseil-wrap-unique check

Eugene.Zelenko added inline comments. Comment at: clang-tidy/abseil/WrapUniqueCheck.cpp:80 + if (cons) { +if (cons->isListInitialization()) { + return; Please elide braces. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57435/new/ https://revi

[PATCH] D57435: [clang-tidy] Add abseil-wrap-unique check

Dosi-Dough updated this revision to Diff 184431. Dosi-Dough marked 11 inline comments as done. Dosi-Dough added a comment. fixed white space/ formatting issues. removed .DS_Store. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57435/new/ https://reviews.llvm.org/D57435 Files: clang-t

[PATCH] D57435: [clang-tidy] Add abseil-wrap-unique check

Eugene.Zelenko added inline comments. Comment at: clang-tidy/abseil/AbseilTidyModule.cpp:61 +"abseil-wrap-unique"); + + } Unnecessary empty line. Comment at: clang-tidy/abseil/WrapUniqueCheck.cpp:10 + +#include +#include "WrapUniqueCh