Eugene.Zelenko added inline comments.
================
Comment at: clang-tidy/abseil/WrapUniqueCheck.h:26
+private:
+ // std::string getArgs(const SourceManager *SM, const CallExpr *MemExpr);
+
----------------
Please remove obsolete commend and private keyword.
================
Comment at: docs/clang-tidy/checks/abseil-wrap-unique.rst:5
+==================
+Looks for instances of factory functions which uses a non-public constructor
+that returns a ``std::unqiue_ptr<T>`` then recommends using
----------------
Please separate with empty line.
================
Comment at: docs/clang-tidy/checks/abseil-wrap-unique.rst:16
+ private:
+ A() {}
+ };
----------------
Please use = default;
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D57435/new/
https://reviews.llvm.org/D57435
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
