[PATCH] D56225: [HIP] Use nul instead of /dev/null when running on windows

This revision was automatically updated to reflect the committed changes. Closed by commit rL350885: [HIP] Use nul instead of /dev/null when running on windows (authored by yaxunl, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D56225?

[PATCH] D56225: [HIP] Use nul instead of /dev/null when running on windows

rjmccall accepted this revision. rjmccall added inline comments. This revision is now accepted and ready to land. Comment at: lib/Driver/ToolChains/HIP.cpp:210 std::string BundlerTargetArg = "-targets=host-x86_64-unknown-linux"; - std::string BundlerInputArg = "-inputs=/dev/n

[PATCH] D56225: [HIP] Use nul instead of /dev/null when running on windows

yaxunl marked an inline comment as done. yaxunl added inline comments. Comment at: lib/Driver/ToolChains/HIP.cpp:210 std::string BundlerTargetArg = "-targets=host-x86_64-unknown-linux"; - std::string BundlerInputArg = "-inputs=/dev/null"; + std::string BundlerInputArg = "-in

[PATCH] D56225: [HIP] Use nul instead of /dev/null when running on windows

rjmccall added inline comments. Comment at: lib/Driver/ToolChains/HIP.cpp:210 std::string BundlerTargetArg = "-targets=host-x86_64-unknown-linux"; - std::string BundlerInputArg = "-inputs=/dev/null"; + std::string BundlerInputArg = "-inputs=" NULL_FILE; Ho

[PATCH] D56225: [HIP] Use nul instead of /dev/null when running on windows

yaxunl created this revision. yaxunl added a reviewer: tra. When clang is running on windows, /dev/null is not available. Use nul as empty input file instead. https://reviews.llvm.org/D56225 Files: lib/Driver/ToolChains/HIP.cpp Index: lib/Driver/ToolChains/HIP.cpp =