rjmccall accepted this revision. rjmccall added inline comments. This revision is now accepted and ready to land.
================ Comment at: lib/Driver/ToolChains/HIP.cpp:210 std::string BundlerTargetArg = "-targets=host-x86_64-unknown-linux"; - std::string BundlerInputArg = "-inputs=/dev/null"; + std::string BundlerInputArg = "-inputs=" NULL_FILE; ---------------- yaxunl wrote: > rjmccall wrote: > > How hard would it be to just implement the TODO and get away from a > > reliance on a null file? > I tried to make clang-offloader-bundler work without host target but it is > not easy. Since it is shared with other languages e.g. OpenMP, it has a > fundamental assumption that there is one host target. To make it work without > host target may result in format changes that affecting HIP runtime, which is > something I would like to avoid for now. Okay, if this is the only reasonable way you can find to do it, it's fine. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56225/new/ https://reviews.llvm.org/D56225 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
