This revision was automatically updated to reflect the committed changes.
Closed by commit rL350108: [gn build] Add check-clang target and make it work
(authored by nico, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D56095?vs=179563&
phosek accepted this revision.
phosek added a comment.
This revision is now accepted and ready to land.
LGTM
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D56095/new/
https://reviews.llvm.org/D56095
___
cfe-commits mailing list
cfe-commits@l
thakis updated this revision to Diff 179563.
thakis added a comment.
s/missing/unimplemented/
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D56095/new/
https://reviews.llvm.org/D56095
Files:
llvm/utils/gn/secondary/BUILD.gn
llvm/utils/gn/secondary/clang/test/BUILD.gn
llvm/utils/gn
thakis marked an inline comment as done.
thakis added inline comments.
Comment at: llvm/utils/gn/secondary/llvm/triples.gni:10
+} else {
+ assert(false, "missing host_cpu " + host_cpu)
}
phosek wrote:
> I don't think `host_cpu` would ever be missing since it's
phosek added inline comments.
Comment at: llvm/utils/gn/secondary/llvm/triples.gni:10
+} else {
+ assert(false, "missing host_cpu " + host_cpu)
}
I don't think `host_cpu` would ever be missing since it's detected by GN
(unless it's a new architecture that GN d
thakis marked an inline comment as done.
thakis added inline comments.
Comment at: llvm/utils/gn/secondary/clang/test/BUILD.gn:23
+
+ "LIT_SITE_CFG_IN_HEADER=## Autogenerated from ${sources[0]}, do not
edit",
+ "CLANG_BINARY_DIR=" +
As you can see, thi
thakis created this revision.
thakis added a reviewer: phosek.
With this, check-clang runs and passes all of clang's lit tests. It doesn't run
any of its unit tests yet.
Like with check-lld, running just ninja -C out/gn will build all prerequisites
needed to run tests, but it won't run the test
