phosek added inline comments.

================
Comment at: llvm/utils/gn/secondary/llvm/triples.gni:10
+} else {
+  assert(false, "missing host_cpu " + host_cpu)
 }
----------------
I don't think `host_cpu` would ever be missing since it's detected by GN 
(unless it's a new architecture that GN doesn't recognize), should this rather 
be `unsupported host_cpu` or something along those lines?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56095/new/

https://reviews.llvm.org/D56095



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to