This revision was not accepted when it landed; it landed in state "Needs
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit rL351371: [Fixed Point Arithmetic] Fixed Point Subtraction
(authored by leonardchan, committed by ).
Herald added a subscrib
rjmccall added a comment.
I don't pay attention to "ready to land" because I assume that you're verifying
that your patch actually works as promised in practice, at least as far as the
tests are concerned (and presumably my review catches deeper issues). If there
are substantial changes that la
leonardchan added inline comments.
Comment at: clang/lib/CodeGen/CGExprScalar.cpp:3451
+ case BO_Comma:
+llvm_unreachable("Found unimplemented fixed point binary operation");
}
rjmccall wrote:
> Please create a separate case for the non-arithmetic operato
leonardchan updated this revision to Diff 182108.
leonardchan marked 2 inline comments as done.
Repository:
rC Clang
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D55844/new/
https://reviews.llvm.org/D55844
Files:
clang/lib/CodeGen/CGExprScalar.cpp
clang/test/Frontend/fixed_point_s
rjmccall added inline comments.
Comment at: clang/lib/CodeGen/CGExprScalar.cpp:3451
+ case BO_Comma:
+llvm_unreachable("Found unimplemented fixed point binary operation");
}
Please create a separate case for the non-arithmetic operators
(pointer-to-membe
leonardchan updated this revision to Diff 180920.
leonardchan marked an inline comment as done.
Repository:
rC Clang
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D55844/new/
https://reviews.llvm.org/D55844
Files:
clang/lib/CodeGen/CGExprScalar.cpp
clang/test/Frontend/fixed_point_s
rjmccall added inline comments.
Comment at: clang/lib/CodeGen/CGExprScalar.cpp:3397
Value *Result;
- if (ResultFixedSema.isSaturated()) {
-llvm::Intrinsic::ID IID = ResultFixedSema.isSigned()
- ? llvm::Intrinsic::sadd_sat
-
leonardchan created this revision.
leonardchan added reviewers: ebevhan, bjope, rjmccall.
leonardchan added a project: clang.
This patch covers subtraction between fixed point types and other fixed point
types or integers, using the conversion rules described in 4.1.4 of N1169.
Repository:
rC
