Anastasia requested changes to this revision.
Anastasia added a comment.
This revision now requires changes to proceed.
@mikael can you please close this review, because I opened another one to
continue this: https://reviews.llvm.org/D56066.
Thanks for your work!
Repository:
rC Clang
CHANGE
Anastasia added inline comments.
Comment at: lib/AST/ASTContext.cpp:2781
+
+ return getAddrSpaceQualType(NewT, Orig.getAddressSpace());
}
ebevhan wrote:
> rjmccall wrote:
> > Anastasia wrote:
> > > rjmccall wrote:
> > > > You're trying to handle a method qualif
ebevhan added inline comments.
Comment at: lib/AST/ASTContext.cpp:2781
+
+ return getAddrSpaceQualType(NewT, Orig.getAddressSpace());
}
rjmccall wrote:
> Anastasia wrote:
> > rjmccall wrote:
> > > You're trying to handle a method qualifier, not a type a functio
rjmccall added inline comments.
Comment at: lib/AST/ASTContext.cpp:2781
+
+ return getAddrSpaceQualType(NewT, Orig.getAddressSpace());
}
Anastasia wrote:
> rjmccall wrote:
> > You're trying to handle a method qualifier, not a type a functions that are
> > them
Anastasia added inline comments.
Comment at: lib/AST/ASTContext.cpp:2781
+
+ return getAddrSpaceQualType(NewT, Orig.getAddressSpace());
}
rjmccall wrote:
> You're trying to handle a method qualifier, not a type a functions that are
> themselves in some non-sta
rjmccall added inline comments.
Comment at: lib/AST/ASTContext.cpp:2781
+
+ return getAddrSpaceQualType(NewT, Orig.getAddressSpace());
}
You're trying to handle a method qualifier, not a type a functions that are
themselves in some non-standard address space,
mikael marked an inline comment as done.
mikael added inline comments.
Comment at: lib/Sema/SemaInit.cpp:4539
+ if (InitCategory.isPRValue() || InitCategory.isXValue())
+T1Quals.removeAddressSpace();
+
This is probably not the correct way to solve this. But
mikael created this revision.
mikael added reviewers: Anastasia, rjmccall.
Herald added subscribers: cfe-commits, yaxunl.
- Implicity and explicity defaulted class members
- Resolved the FIXMEs in addrspace-of-this.cl
Repository:
rC Clang
https://reviews.llvm.org/D55656
Files:
include/clan
