Anastasia added inline comments.

================
Comment at: lib/AST/ASTContext.cpp:2781
+
+  return getAddrSpaceQualType(NewT, Orig.getAddressSpace());
 }
----------------
rjmccall wrote:
> You're trying to handle a method qualifier, not a type a functions that are 
> themselves in some non-standard address space, right?  The method qualifier 
> should already be part of `Proto->getExtProtoInfo()`, so if there's an 
> address space qualifier out here, something is very wrong.
As far as I understand the new design, we have an address space qualifier on a 
method and as a part of the function prototype too. Are you saying that we need 
to make sure the prototype has an address space too?


Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55656/new/

https://reviews.llvm.org/D55656



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to