This revision was automatically updated to reflect the committed changes.
Closed by commit rL349049: [clangd] Enable cross-namespace completions by
default in clangd (authored by ioeric, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
CHANGES SINCE LAST ACTION
ht
ilya-biryukov accepted this revision.
ilya-biryukov added a comment.
LGTM. When we know everyone is happy with the new behaivour, we can remove the
flag altogether.
Comment at: clangd/tool/ClangdMain.cpp:144
"can insert scope qualifiers."),
-cl::init(false), cl::H
kadircet added inline comments.
Comment at: clangd/tool/ClangdMain.cpp:144
"can insert scope qualifiers."),
-cl::init(false), cl::Hidden);
+cl::init(true));
ioeric wrote:
> kadircet wrote:
> > why not keep it hidden ?
> We hid the flag because
ioeric marked an inline comment as done.
ioeric added inline comments.
Comment at: clangd/tool/ClangdMain.cpp:144
"can insert scope qualifiers."),
-cl::init(false), cl::Hidden);
+cl::init(true));
kadircet wrote:
> why not keep it hidden ?
We hi
kadircet added inline comments.
Comment at: clangd/tool/ClangdMain.cpp:144
"can insert scope qualifiers."),
-cl::init(false), cl::Hidden);
+cl::init(true));
why not keep it hidden ?
Repository:
rCTE Clang Tools Extra
CHANGES SINCE LAST ACT
ioeric created this revision.
ioeric added reviewers: hokein, ilya-biryukov, kadircet.
Herald added subscribers: cfe-commits, arphaman, jkorous, MaskRay.
Code completion will suggest symbols from any scope (incl. inaccessible
scopes) when there's no qualifier explicitly specified. As we are assign
