ilya-biryukov accepted this revision.
ilya-biryukov added a comment.
LGTM. When we know everyone is happy with the new behaivour, we can remove the
flag altogether.
================
Comment at: clangd/tool/ClangdMain.cpp:144
"can insert scope qualifiers."),
- cl::init(false), cl::Hidden);
+ cl::init(true));
----------------
kadircet wrote:
> ioeric wrote:
> > kadircet wrote:
> > > why not keep it hidden ?
> > We hid the flag because the feature was experimental. Now that it's the
> > default, I think it makes sense to expose the flag.
> I wouldn't expect anyone to turn it off, but not that important.
+1 to making it visible. Now that actually enable it by default, it would be
nice if the users could find it and turn it off in case they need it.
Repository:
rCTE Clang Tools Extra
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D55649/new/
https://reviews.llvm.org/D55649
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
