This revision was automatically updated to reflect the committed changes.
Closed by commit rC348977: [AST] Store "UsesADL" information in
CallExpr. (authored by EricWF, committed by ).
Repository:
rC Clang
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D55534/new/
https://reviews.llvm.o
EricWF updated this revision to Diff 177907.
EricWF marked an inline comment as done.
EricWF added a comment.
Address final review comments.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D55534/new/
https://reviews.llvm.org/D55534
Files:
docs/LibASTMatchersReference.html
include/cla
rsmith accepted this revision.
rsmith added inline comments.
This revision is now accepted and ready to land.
Comment at: include/clang/ASTMatchers/ASTMatchers.h:1276
+/// y(42); // Doesn't match
+/// }
+/// \endcode
I think it would be useful to add to the
EricWF marked an inline comment as done.
EricWF added inline comments.
Comment at: docs/LibASTMatchersReference.html:2579-2581
+y(x); Matches
+NS::y(x); Doesn't match
+y(42); Doesn't match.
aaron.ballman wrote:
> EricWF wrote:
> > aaron.ballman wrote:
EricWF marked an inline comment as done.
EricWF added a comment.
I think this is good to go. Any more comments?
Comment at: include/clang/Sema/Sema.h:2758
bool AllowExplicit = false,
+bool IsADLCandidate = false,
EricWF updated this revision to Diff 177752.
EricWF marked 3 inline comments as done.
EricWF added a comment.
Address review comments.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D55534/new/
https://reviews.llvm.org/D55534
Files:
docs/LibASTMatchersReference.html
include/clang/AST
EricWF marked 13 inline comments as done.
EricWF added inline comments.
Comment at: include/clang/Sema/Sema.h:2758
bool AllowExplicit = false,
+bool IsADLCandidate = false,
ConversionSequenceLis
riccibruno added inline comments.
Comment at: lib/AST/Expr.cpp:1267
: Expr(SC, Empty), NumArgs(NumArgs) {
+ CallExprBits.UsesADL = false;
CallExprBits.NumPreArgs = NumPreArgs;
riccibruno wrote:
> I believe that msan can cope with bit level operations jus
rsmith added inline comments.
Comment at: include/clang/Sema/Sema.h:2758
bool AllowExplicit = false,
+bool IsADLCandidate = false,
ConversionSequenceList EarlyConversions = None);
--
riccibruno added inline comments.
Comment at: lib/AST/Expr.cpp:1267
: Expr(SC, Empty), NumArgs(NumArgs) {
+ CallExprBits.UsesADL = false;
CallExprBits.NumPreArgs = NumPreArgs;
I believe that msan can cope with bit level operations just fine.
What I am af
aaron.ballman added inline comments.
Comment at: docs/LibASTMatchersReference.html:2579-2581
+y(x); Matches
+NS::y(x); Doesn't match
+y(42); Doesn't match.
EricWF wrote:
> aaron.ballman wrote:
> > This is not your bug to fix, but it seems the document
EricWF marked 3 inline comments as done.
EricWF added a comment.
Address more inline comments.
Comment at: docs/LibASTMatchersReference.html:2579-2581
+y(x); Matches
+NS::y(x); Doesn't match
+y(42); Doesn't match.
aaron.ballman wrote:
> This is not
aaron.ballman marked an inline comment as done.
aaron.ballman added a comment.
A few more minor nits.
Comment at: docs/LibASTMatchersReference.html:2579-2581
+y(x); Matches
+NS::y(x); Doesn't match
+y(42); Doesn't match.
This is not your bug to fix,
EricWF updated this revision to Diff 177720.
EricWF marked 2 inline comments as done.
EricWF added a comment.
Register matcher and regenerate docs.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D55534/new/
https://reviews.llvm.org/D55534
Files:
docs/LibASTMatchersReference.html
incl
EricWF updated this revision to Diff 177716.
EricWF added a comment.
More tests.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D55534/new/
https://reviews.llvm.org/D55534
Files:
include/clang/AST/Expr.h
include/clang/AST/ExprCXX.h
include/clang/AST/Stmt.h
include/clang/ASTMatche
aaron.ballman added inline comments.
Comment at: include/clang/ASTMatchers/ASTMatchers.h:1260
+/// Matches call expressions which were resolved using ADL.
+///
Don't forget to regenerate the documentation and update Registry.cpp to add
clang-query support.
C
riccibruno added inline comments.
Comment at: lib/AST/Expr.cpp:1267
: Expr(SC, Empty), NumArgs(NumArgs) {
+ CallExprBits.UsesADL = false;
CallExprBits.NumPreArgs = NumPreArgs;
It do not really matter but there is not point initializing this bit here.
C
EricWF updated this revision to Diff 177705.
EricWF marked an inline comment as done.
EricWF added a comment.
Update with fixes for review comments.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D55534/new/
https://reviews.llvm.org/D55534
Files:
include/clang/AST/Expr.h
include/clan
EricWF marked 12 inline comments as done.
EricWF added a comment.
Address more review comments. Update incoming.
Comment at: include/clang/AST/Expr.h:2425
CallExpr(const ASTContext &C, StmtClass SC, unsigned NumPreArgs,
- unsigned NumArgs, EmptyShell Empty);
+
riccibruno added inline comments.
Comment at: include/clang/AST/Expr.h:2425
CallExpr(const ASTContext &C, StmtClass SC, unsigned NumPreArgs,
- unsigned NumArgs, EmptyShell Empty);
+ unsigned NumArgs, bool UsesADL, EmptyShell Empty);
There
EricWF marked 14 inline comments as done.
EricWF added a comment.
Address review comments. Fixes incoming.
Comment at: include/clang/AST/ExprCXX.h:218
+ SourceLocation RP, unsigned MinNumArgs = 0,
+ bool UsesADL = false)
: CallExpr
fowles added inline comments.
Comment at: include/clang/AST/ExprCXX.h:218
+ SourceLocation RP, unsigned MinNumArgs = 0,
+ bool UsesADL = false)
: CallExpr(C, CUDAKernelCallExprClass, fn, Config, args, t, VK, RP,
Can
EricWF created this revision.
EricWF added reviewers: fowles, rsmith, klimek.
Herald added a reviewer: shafik.
Currently the Clang AST doesn't store information about how the callee of a
CallExpr was found. Specifically if it was found using ADL.
However, this information is invaluable to toolin
23 matches
Mail list logo
