EricWF marked 3 inline comments as done.
EricWF added a comment.
Address more inline comments.
================
Comment at: docs/LibASTMatchersReference.html:2579-2581
+ y(x); Matches
+ NS::y(x); Doesn't match
+ y(42); Doesn't match.
----------------
aaron.ballman wrote:
> This is not your bug to fix, but it seems the documentation generator is
> stripping the comment markers. This impacts other matchers as well, such as
> `throughUsingDecl()`.
I wonder if it strips `/**/` comments. I don't want to get blocked on this.
================
Comment at: lib/AST/Expr.cpp:1267
: Expr(SC, Empty), NumArgs(NumArgs) {
+ CallExprBits.UsesADL = false;
CallExprBits.NumPreArgs = NumPreArgs;
----------------
riccibruno wrote:
> It do not really matter but there is not point initializing this bit here.
I'm a but nervous MSAN won't catch an uninitialized read because it's a
bitfield, so I would rather be safe than sorry?
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D55534/new/
https://reviews.llvm.org/D55534
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
