[PATCH] D55188: Extract TextChildDumper class

This revision was automatically updated to reflect the committed changes. Closed by commit rL348410: NFC: Extract TextTreeStructure class (authored by steveire, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D55188?vs=176467&id=176867#

[PATCH] D55188: Extract TextChildDumper class

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM aside from a commenting nit. Comment at: include/clang/AST/ASTDumperUtils.h:112 +public: + /// Dump a child of the current node. + template void addChil

[PATCH] D55188: Extract TextChildDumper class

steveire updated this revision to Diff 176467. steveire added a comment. Remove namespace Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55188/new/ https://reviews.llvm.org/D55188 Files: include/clang/AST/ASTDumperUtils.h lib/AST/ASTDumper.cpp Index: lib/AST

[PATCH] D55188: Extract TextChildDumper class

steveire updated this revision to Diff 176466. steveire added a comment. Rename class. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55188/new/ https://reviews.llvm.org/D55188 Files: include/clang/AST/ASTDumperUtils.h lib/AST/ASTDumper.cpp Index: lib/AST/AS

[PATCH] D55188: Extract TextChildDumper class

aaron.ballman added inline comments. Comment at: include/clang/AST/ASTDumperUtils.h:22 + +namespace ast_dumper { +// Colors used for various parts of the AST dump steveire wrote: > aaron.ballman wrote: > > steveire wrote: > > > aaron.ballman wrote: > > > > I'm no

[PATCH] D55188: Extract TextChildDumper class

steveire marked an inline comment as done. steveire added inline comments. Comment at: include/clang/AST/ASTDumperUtils.h:96 + +struct TextChildDumper { + raw_ostream &OS; steveire wrote: > aaron.ballman wrote: > > I'm not sold on the name for this class. It's a

[PATCH] D55188: Extract TextChildDumper class

steveire marked 2 inline comments as done. steveire added inline comments. Comment at: include/clang/AST/ASTDumperUtils.h:22 + +namespace ast_dumper { +// Colors used for various parts of the AST dump aaron.ballman wrote: > steveire wrote: > > aaron.ballman wrote

[PATCH] D55188: Extract TextChildDumper class

aaron.ballman added inline comments. Comment at: include/clang/AST/ASTDumperUtils.h:22 + +namespace ast_dumper { +// Colors used for various parts of the AST dump steveire wrote: > aaron.ballman wrote: > > I'm not certain this namespace is useful, especially when

[PATCH] D55188: Extract TextChildDumper class

steveire marked an inline comment as done. steveire added inline comments. Comment at: include/clang/AST/ASTDumperUtils.h:22 + +namespace ast_dumper { +// Colors used for various parts of the AST dump aaron.ballman wrote: > I'm not certain this namespace is usefu

[PATCH] D55188: Extract TextChildDumper class

aaron.ballman added inline comments. Comment at: include/clang/AST/ASTDumperUtils.h:22 + +namespace ast_dumper { +// Colors used for various parts of the AST dump I'm not certain this namespace is useful, especially when it gets imported at TU scope in ASTDumper

[PATCH] D55188: Extract TextChildDumper class

steveire created this revision. steveire added a reviewer: aaron.ballman. Herald added a subscriber: cfe-commits. Repository: rC Clang https://reviews.llvm.org/D55188 Files: include/clang/AST/ASTDumperUtils.h lib/AST/ASTDumper.cpp Index: lib/AST/ASTDumper.cpp =