aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
LGTM aside from a commenting nit.
================
Comment at: include/clang/AST/ASTDumperUtils.h:112
+public:
+ /// Dump a child of the current node.
+ template <typename Fn> void addChild(Fn doAddChild) {
----------------
I really like the rename, but can you update this comment to not say "dump" as
that implies to me that the writing happens immediately. It might also be a
kindness to add the expected function signature of `Fn` to the comments.
Repository:
rC Clang
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D55188/new/
https://reviews.llvm.org/D55188
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
