[PATCH] D55049: Changed every use of ASTImporter::Import to Import_New

This revision was automatically updated to reflect the committed changes. Closed by commit rC357913: Changed every use of ASTImporter::Import to Import_New (authored by balazske, committed by ). Changed prior to commit: https://reviews.llvm.org/D55049?vs=192110&id=194140#toc Repository: rC C

[PATCH] D55049: Changed every use of ASTImporter::Import to Import_New

a_sidorin accepted this revision. a_sidorin added a comment. This revision is now accepted and ready to land. LGTM. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55049/new/ https://reviews.llvm.org/D55049 ___ cfe-com

[PATCH] D55049: Changed every use of ASTImporter::Import to Import_New

martong added a comment. Ping @shafik @a_sidorin Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55049/new/ https://reviews.llvm.org/D55049 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org

[PATCH] D55049: Changed every use of ASTImporter::Import to Import_New

balazske updated this revision to Diff 192110. balazske added a comment. Corrected rebase problems. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55049/new/ https://reviews.llvm.org/D55049 Files: lib/AST/ASTImporter.cpp lib/AST/ExternalASTMerger.cpp lib/Cr

[PATCH] D55049: Changed every use of ASTImporter::Import to Import_New

balazske updated this revision to Diff 192105. balazske added a comment. - Rebase to current master. - Fixed error handling in testImport. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55049/new/ https://reviews.llvm.org/D55049 Files: lib/AST/ASTImporter.cpp

[PATCH] D55049: Changed every use of ASTImporter::Import to Import_New

balazske marked an inline comment as done. balazske added inline comments. Comment at: lib/AST/ASTImporter.cpp:8550 +if (ExpectedType ToFromOrErr = Import_New(From)) { + if (ToContext.hasSameType(*ToFromOrErr, To)) +return true; a_sidorin wrote:

[PATCH] D55049: Changed every use of ASTImporter::Import to Import_New

a_sidorin added a comment. Hi Balazs, The looks mostly good to me. Comment at: lib/AST/ASTImporter.cpp:3440 - for (const auto *Attr : D->attrs()) -ToIndirectField->addAttr(Importer.Import(Attr)); There is the same deletion in D53757.

[PATCH] D55049: Changed every use of ASTImporter::Import to Import_New

martong added a reviewer: a_sidorin. martong added a comment. Herald added a subscriber: rnkovacs. Ping Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55049/new/ https://reviews.llvm.org/D55049 ___ cfe-commits mailing

[PATCH] D55049: Changed every use of ASTImporter::Import to Import_New

martong added inline comments. Herald added a reviewer: martong. Herald added a project: clang. Comment at: lib/AST/ASTImporter.cpp:7767 + if (!ToDCOrErr) +return ToDCOrErr.takeError(); + auto *ToDC = cast(*ToDCOrErr); Actually, this patch is not merely a `

[PATCH] D55049: Changed every use of ASTImporter::Import to Import_New

balazske updated this revision to Diff 175864. balazske added a comment. - Changed some missing Import calls. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55049/new/ https://reviews.llvm.org/D55049 Files: lib/AST/ASTImporter.cpp lib/AST/ExternalASTMerger.cp

[PATCH] D55049: Changed every use of ASTImporter::Import to Import_New

balazske created this revision. Herald added subscribers: cfe-commits, gamesh411, Szelethus, martong, dkrupp. Herald added a reviewer: a.sidorin. Herald added a reviewer: shafik. Repository: rC Clang https://reviews.llvm.org/D55049 Files: lib/AST/ExternalASTMerger.cpp lib/CrossTU/CrossTran