balazske marked an inline comment as done.
balazske added inline comments.
================
Comment at: lib/AST/ASTImporter.cpp:8550
+ if (ExpectedType ToFromOrErr = Import_New(From)) {
+ if (ToContext.hasSameType(*ToFromOrErr, To))
+ return true;
----------------
a_sidorin wrote:
> Wow, we import types instead of just checking them for structural
> equivalence. That's OK to leave it in the patch as-is but looks pretty
> strange. Maybe this even deserves a FIXME.
The Import call was already here: "ToContext.hasSameType(**Import(From)**, To))"
This is not a big thing, because the type already exists in ImportedTypes, so
the Import call will return it.
Repository:
rC Clang
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D55049/new/
https://reviews.llvm.org/D55049
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
