[PATCH] D54676: [AST] Pack CallExpr

2018-12-17 Thread Bruno Ricci via Phabricator via cfe-commits
riccibruno abandoned this revision. riccibruno added a comment. Abandoned in favor of D55771 Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54676/new/ https://reviews.llvm.org/D54676

[PATCH] D54676: [AST] Pack CallExpr

2018-11-19 Thread Bruno Ricci via Phabricator via cfe-commits
riccibruno planned changes to this revision. riccibruno added a comment. In https://reviews.llvm.org/D54676#1303176, @rjmccall wrote: > You can have more arguments than parameters because of varargs. Even putting > that aside, no, I think we generally shouldn't go backwards on these limits. >

[PATCH] D54676: [AST] Pack CallExpr

2018-11-19 Thread John McCall via Phabricator via cfe-commits
rjmccall added a comment. You can have more arguments than parameters because of varargs. Even putting that aside, no, I think we generally shouldn't go backwards on these limits. Anyway, packing right up to the limits imposed by `NumExprBits` probably isn't a great idea. Repository: rC C

[PATCH] D54676: [AST] Pack CallExpr

2018-11-19 Thread Bruno Ricci via Phabricator via cfe-commits
riccibruno added a comment. In https://reviews.llvm.org/D54676#1302510, @rjmccall wrote: > I don't think we should be reducing the number of call arguments we can > support, sorry, even if 16K is a fairly absurd number that would probably > trip stack overflow protections if you actually execut

[PATCH] D54676: [AST] Pack CallExpr

2018-11-18 Thread John McCall via Phabricator via cfe-commits
rjmccall added a comment. I don't think we should be reducing the number of call arguments we can support, sorry, even if 16K is a fairly absurd number that would probably trip stack overflow protections if you actually executed it. Let's try to keep it at least 64K-ish. Repository: rC Cla

[PATCH] D54676: [AST] Pack CallExpr

2018-11-18 Thread Bruno Ricci via Phabricator via cfe-commits
riccibruno created this revision. riccibruno added a reviewer: rjmccall. riccibruno added a project: clang. Herald added a subscriber: cfe-commits. Use the newly available space in the bit-fields of `Stmt` to store some data from `CallExpr`. This saves 8 bytes per `CallExpr`. This is a straightfo