[PATCH] D54425: [AArch64] Add aarch64_vector_pcs function attribute to Clang

This revision was automatically updated to reflect the committed changes. Closed by commit rC347571: [AArch64] Add aarch64_vector_pcs function attribute to Clang (authored by s.desmalen, committed by ). Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54425/new/ http

[PATCH] D54425: [AArch64] Add aarch64_vector_pcs function attribute to Clang

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. Thanks, LGTM. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54425/new/ https://reviews.llvm.org/D54425 ___ cfe-commits mailing list

[PATCH] D54425: [AArch64] Add aarch64_vector_pcs function attribute to Clang

sdesmalen updated this revision to Diff 175236. sdesmalen added a comment. - resolved editorial comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54425/new/ https://reviews.llvm.org/D54425 Files: include/clang-c/Index.h include/clang/Basic/Attr.td include/clang/Basic/AttrDo

[PATCH] D54425: [AArch64] Add aarch64_vector_pcs function attribute to Clang

aaron.ballman added a comment. In D54425#1307838 , @sdesmalen wrote: > Just to double check before committing, @aaron.ballman are you happy with the > tests? The tests LGTM, but there are still some unresolved comments from @rjmccall that should be han

[PATCH] D54425: [AArch64] Add aarch64_vector_pcs function attribute to Clang

sdesmalen added a comment. Just to double check before committing, @aaron.ballman are you happy with the tests? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54425/new/ https://reviews.llvm.org/D54425 ___ cfe-commits mailing list cfe-commi

[PATCH] D54425: [AArch64] Add aarch64_vector_pcs function attribute to Clang

rjmccall added a comment. Implementation LGTM. Comment at: include/clang/Basic/AttrDocs.td:1753 +This means it is more efficient to call such functions from code that performs +extensive floating-point and vector calculations, because fewer live SIMD&FP +registers need to be sa

[PATCH] D54425: [AArch64] Add aarch64_vector_pcs function attribute to Clang

sdesmalen added a subscriber: keith.walker.arm. sdesmalen added inline comments. Comment at: lib/CodeGen/CGDebugInfo.cpp:1101 case CC_AAPCS: + case CC_AArch64VectorCall: return llvm::dwarf::DW_CC_LLVM_AAPCS; rjmccall wrote: > rnk wrote: > > sdesmalen wro

[PATCH] D54425: [AArch64] Add aarch64_vector_pcs function attribute to Clang

sdesmalen updated this revision to Diff 174574. sdesmalen marked an inline comment as done. sdesmalen added a comment. Thanks all for the suggestions and comments! I've updated the patch with a better description of the attribute's behaviour (thanks @rjmccall for the starting point!) and added S

[PATCH] D54425: [AArch64] Add aarch64_vector_pcs function attribute to Clang

rjmccall added inline comments. Comment at: lib/CodeGen/CGDebugInfo.cpp:1101 case CC_AAPCS: + case CC_AArch64VectorCall: return llvm::dwarf::DW_CC_LLVM_AAPCS; rnk wrote: > sdesmalen wrote: > > I wasn't really sure whether this requires a corresponding >

[PATCH] D54425: [AArch64] Add aarch64_vector_pcs function attribute to Clang

rnk added inline comments. Comment at: lib/CodeGen/CGDebugInfo.cpp:1101 case CC_AAPCS: + case CC_AArch64VectorCall: return llvm::dwarf::DW_CC_LLVM_AAPCS; sdesmalen wrote: > I wasn't really sure whether this requires a corresponding DW_CC_LLVM_AAVPCS > r

[PATCH] D54425: [AArch64] Add aarch64_vector_pcs function attribute to Clang

rjmccall added inline comments. Comment at: include/clang/Basic/AttrDocs.td:1749-1750 +On 64-bit ARM targets, this argument causes the function to obey the vector +procedural call standard (VPCS) rules as described in the Vector ABI for +AArch64. In particular, the register calle

[PATCH] D54425: [AArch64] Add aarch64_vector_pcs function attribute to Clang

aaron.ballman added a comment. Missing sema tests that demonstrate the attribute can only appertain to functions and types, accepts no arguments, has the expected semantic behavior for typecasts to function pointers, etc. Comment at: include/clang/Basic/Attr.td:1792 + let Sp

[PATCH] D54425: [AArch64] Add aarch64_vector_pcs function attribute to Clang

sdesmalen updated this revision to Diff 173831. sdesmalen added a comment. - Removed `_aarch64_vector_pcs` and `__aarch64_vector_pcs` keywords in favour of supporting only `__attribute__(aarch64_vector_pcs))`. https://reviews.llvm.org/D54425 Files: include/clang-c/Index.h include/clang/Bas

[PATCH] D54425: [AArch64] Add aarch64_vector_pcs function attribute to Clang

sdesmalen marked an inline comment as done. sdesmalen added inline comments. Comment at: include/clang/Basic/Attr.td:1792 + let Spellings = [GNU<"aarch64_vector_pcs">, + CXX11<"clang", "aarch64_vector_pcs">, + Keyword<"__aarch64_vector_pcs">,

[PATCH] D54425: [AArch64] Add aarch64_vector_pcs function attribute to Clang

aaron.ballman added inline comments. Comment at: include/clang/Basic/Attr.td:1792 + let Spellings = [GNU<"aarch64_vector_pcs">, + CXX11<"clang", "aarch64_vector_pcs">, + Keyword<"__aarch64_vector_pcs">, Rather than using GNU a

[PATCH] D54425: [AArch64] Add aarch64_vector_pcs function attribute to Clang

sdesmalen added inline comments. Comment at: lib/CodeGen/CGDebugInfo.cpp:1101 case CC_AAPCS: + case CC_AArch64VectorCall: return llvm::dwarf::DW_CC_LLVM_AAPCS; I wasn't really sure whether this requires a corresponding DW_CC_LLVM_AAVPCS record in LLVM,

[PATCH] D54425: [AArch64] Add aarch64_vector_pcs function attribute to Clang

sdesmalen created this revision. sdesmalen added reviewers: ributzka, rjmccall, rnk, aaron.ballman. Herald added subscribers: arphaman, kristof.beyls, javed.absar. This is the Clang patch to complement the following LLVM patches: https://reviews.llvm.org/D51477 https://reviews.llvm.org/D51479