rnk added inline comments.

================
Comment at: lib/CodeGen/CGDebugInfo.cpp:1101
   case CC_AAPCS:
+  case CC_AArch64VectorCall:
     return llvm::dwarf::DW_CC_LLVM_AAPCS;
----------------
sdesmalen wrote:
> I wasn't really sure whether this requires a corresponding DW_CC_LLVM_AAVPCS 
> record in LLVM, as I couldn't find much about the DW_CC_LLVM_  encodings, 
> specifically whether they align with some agreed encoding that is implemented 
> by GDB/LLDB. Is this defined anywhere, or is it ignored by debuggers at the 
> moment?
DWARF only allows encoding 256 conventions, and we grabbed 0xC[0-F], I guess 
for "clang", so we probably want to be careful about adding another. Do you 
anticipate making debuggers able to call such functions? If not, it's probably 
not worth it.


https://reviews.llvm.org/D54425



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to