[PATCH] D54404: Exclude matchers which can have multiple results

2018-11-19 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman added inline comments. Comment at: lib/ASTMatchers/Dynamic/Registry.cpp:624 + "hasAnyDeclaration", + "hasAnyName", + "hasAnyParameter", steveire wrote: > aaron.ballman wrote: > > steveire wrote: > > > sbenza wrote: > > > > I'm not sur

[PATCH] D54404: Exclude matchers which can have multiple results

2018-11-19 Thread Stephen Kelly via Phabricator via cfe-commits
steveire added inline comments. Comment at: lib/ASTMatchers/Dynamic/Registry.cpp:624 + "hasAnyDeclaration", + "hasAnyName", + "hasAnyParameter", aaron.ballman wrote: > steveire wrote: > > sbenza wrote: > > > I'm not sure what goes in this list. > >

[PATCH] D54404: Exclude matchers which can have multiple results

2018-11-18 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman added inline comments. Comment at: lib/ASTMatchers/Dynamic/Registry.cpp:624 + "hasAnyDeclaration", + "hasAnyName", + "hasAnyParameter", steveire wrote: > sbenza wrote: > > I'm not sure what goes in this list. > > `hasAnyName` is here

[PATCH] D54404: Exclude matchers which can have multiple results

2018-11-18 Thread Stephen Kelly via Phabricator via cfe-commits
steveire added inline comments. Comment at: lib/ASTMatchers/Dynamic/Registry.cpp:624 + "hasAnyDeclaration", + "hasAnyName", + "hasAnyParameter", sbenza wrote: > I'm not sure what goes in this list. > `hasAnyName` is here but not `hasName`. > What i

[PATCH] D54404: Exclude matchers which can have multiple results

2018-11-14 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman added inline comments. Comment at: lib/ASTMatchers/Dynamic/Registry.cpp:606 + // be used with particular arguments. + static std::vector ExcludedMatchers{ + "allOf", sbenza wrote: > I don't think we are allowed to have non-trivial static stor

[PATCH] D54404: Exclude matchers which can have multiple results

2018-11-13 Thread Samuel Benzaquen via Phabricator via cfe-commits
sbenza added a comment. In https://reviews.llvm.org/D54404#1296224, @aaron.ballman wrote: > In https://reviews.llvm.org/D54404#1295426, @steveire wrote: > > > I acknowledge and share the future-proofing concern. > > > > We could possibly use something trait-based instead and put the trait > > be

[PATCH] D54404: Exclude matchers which can have multiple results

2018-11-13 Thread Stephen Kelly via Phabricator via cfe-commits
steveire added a comment. Let's discuss it on IRC at some point and see if we can come up with wording. Repository: rC Clang https://reviews.llvm.org/D54404 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mai

[PATCH] D54404: Exclude matchers which can have multiple results

2018-11-12 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman added a reviewer: sbenza. aaron.ballman added a subscriber: sbenza. aaron.ballman added a comment. In https://reviews.llvm.org/D54404#1295426, @steveire wrote: > I acknowledge and share the future-proofing concern. > > We could possibly use something trait-based instead and put the

[PATCH] D54404: Exclude matchers which can have multiple results

2018-11-12 Thread Stephen Kelly via Phabricator via cfe-commits
steveire updated this revision to Diff 173766. steveire added a comment. Update Repository: rC Clang https://reviews.llvm.org/D54404 Files: lib/ASTMatchers/Dynamic/Registry.cpp unittests/ASTMatchers/Dynamic/RegistryTest.cpp Index: unittests/ASTMatchers/Dynamic/RegistryTest.cpp

[PATCH] D54404: Exclude matchers which can have multiple results

2018-11-12 Thread Stephen Kelly via Phabricator via cfe-commits
steveire added a comment. I acknowledge and share the future-proofing concern. We could possibly use something trait-based instead and put the trait beside the matcher definition in ASTMatchers.h, but that doesn't really solve the problem. It only moves the problem. Repository: rC Clang ht

[PATCH] D54404: Exclude matchers which can have multiple results

2018-11-11 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman added inline comments. Comment at: lib/ASTMatchers/Dynamic/Registry.cpp:604 + static std::vector excludedMatchers{ + "allOf", `excludedMatchers` -> `ExcludedMatchers` Comment at: lib/ASTMatchers/Dynamic/Registry.cpp:604

[PATCH] D54404: Exclude matchers which can have multiple results

2018-11-11 Thread Stephen Kelly via Phabricator via cfe-commits
steveire created this revision. steveire added a reviewer: aaron.ballman. Herald added a subscriber: cfe-commits. Repository: rC Clang https://reviews.llvm.org/D54404 Files: lib/ASTMatchers/Dynamic/Registry.cpp unittests/ASTMatchers/Dynamic/RegistryTest.cpp Index: unittests/ASTMatchers/D