aaron.ballman added inline comments.
================
Comment at: lib/ASTMatchers/Dynamic/Registry.cpp:604
+ static std::vector<StringRef> excludedMatchers{
+ "allOf",
----------------
`excludedMatchers` -> `ExcludedMatchers`
================
Comment at: lib/ASTMatchers/Dynamic/Registry.cpp:604
+ static std::vector<StringRef> excludedMatchers{
+ "allOf",
----------------
aaron.ballman wrote:
> `excludedMatchers` -> `ExcludedMatchers`
Please add comments that explain why these are excluded and under what
circumstances this list should be updated to add or remove items.
Also: how do we ensure this list stays properly updated? We sometimes miss
updating `RegistryMaps()`, so I'm a bit concerned that adding a second list in
a different location will be inviting trouble.
Repository:
rC Clang
https://reviews.llvm.org/D54404
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
