[PATCH] D54319: clang-cl: Add documentation for /Zc:dllexportInlines-

2018-11-13 Thread Hans Wennborg via Phabricator via cfe-commits
hans marked 3 inline comments as done. hans added a comment. Thanks for the review! I made adjustments in r346748. Comment at: cfe/trunk/docs/UsersManual.rst:3104 + +This causes the class-level `dllexport` and `dllimport` attributes not to be +applied to inline member functions

[PATCH] D54319: clang-cl: Add documentation for /Zc:dllexportInlines-

2018-11-12 Thread Nico Weber via Phabricator via cfe-commits
thakis added a comment. Nice! Comment at: cfe/trunk/docs/UsersManual.rst:2950 /Z7 Enable CodeView debug information in object files + /Zc:dllexportInlines- Don't dllexport/import inline member functions of dllexport/import classes + /Zc:d

[PATCH] D54319: clang-cl: Add documentation for /Zc:dllexportInlines-

2018-11-12 Thread Hans Wennborg via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL346639: clang-cl: Add documentation for /Zc:dllexportInlines- (authored by hans, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D54319?vs=1733

[PATCH] D54319: clang-cl: Add documentation for /Zc:dllexportInlines-

2018-11-10 Thread Takuto Ikuta via Phabricator via cfe-commits
takuto.ikuta accepted this revision. takuto.ikuta added a comment. This revision is now accepted and ready to land. Seems good document! https://reviews.llvm.org/D54319 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cg

[PATCH] D54319: clang-cl: Add documentation for /Zc:dllexportInlines-

2018-11-09 Thread Hans Wennborg via Phabricator via cfe-commits
hans created this revision. hans added reviewers: takuto.ikuta, thakis, rnk. A great feature needs great documentation. Please take a look! https://reviews.llvm.org/D54319 Files: docs/UsersManual.rst include/clang/Driver/CLCompatOptions.td Index: include/clang/Driver/CLCompatOptions.td ===