[PATCH] D54311: Add a test checking clang-tidy can find libc++ on Mac

This revision was automatically updated to reflect the committed changes. Closed by commit rCTE346653: Add a test checking clang-tidy can find libc++ on Mac (authored by ibiryukov, committed by ). Changed prior to commit: https://reviews.llvm.org/D54311?vs=173659&id=173664#toc Repository: rC

[PATCH] D54311: Add a test checking clang-tidy can find libc++ on Mac

ilya-biryukov updated this revision to Diff 173659. ilya-biryukov added a comment. - Check with a clang-tidy warning instead of a clang error Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D54311 Files: test/clang-tidy/Inputs/mock-libcxx/include/c++/v1/mock_vector test/clang

[PATCH] D54311: Add a test checking clang-tidy can find libc++ on Mac

ilya-biryukov updated this revision to Diff 173635. ilya-biryukov marked an inline comment as done. ilya-biryukov added a comment. - Check for a diagnostic inside the found library Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D54311 Files: test/clang-tidy/Inputs/mock-libcxx/

[PATCH] D54311: Add a test checking clang-tidy can find libc++ on Mac

ilya-biryukov marked an inline comment as done. ilya-biryukov added inline comments. Comment at: test/clang-tidy/clang-tidy-mac-libcxx.cpp:11 +// Pretend clang is installed beside the mock library that we provided. +// RUN: echo '[{"directory":"%t","command":"%t/mock-libcxx/bin/c

[PATCH] D54311: Add a test checking clang-tidy can find libc++ on Mac

sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: test/clang-tidy/clang-tidy-mac-libcxx.cpp:11 +// Pretend clang is installed beside the mock library that we provided. +// RUN: echo '[{"directory":"%t",

[PATCH] D54311: Add a test checking clang-tidy can find libc++ on Mac

ilya-biryukov marked an inline comment as done. ilya-biryukov added inline comments. Comment at: test/clang-tidy/clang-tidy-mac-libcxx.cpp:11 +// Pretend clang is installed beside the mock library that we provided. +// RUN: echo '[{"directory":"%t","command":"%t/mock-libcxx/bin/c

[PATCH] D54311: Add a test checking clang-tidy can find libc++ on Mac

ilya-biryukov updated this revision to Diff 173630. ilya-biryukov added a comment. - Updated the test Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D54311 Files: test/clang-tidy/Inputs/mock-libcxx/include/c++/v1/mock_vector test/clang-tidy/clang-tidy-mac-libcxx.cpp Index:

[PATCH] D54311: Add a test checking clang-tidy can find libc++ on Mac

sammccall added inline comments. Comment at: test/clang-tidy/clang-tidy-mac-libcxx.cpp:13 +// RUN: cp "%s" "%t/test.cpp" +// RUN: clang-tidy "%t/test.cpp" + This should check a diagnostic rather than rely on the error code, I think Repository: rCTE Clang Tool

[PATCH] D54311: Add a test checking clang-tidy can find libc++ on Mac

sammccall added inline comments. Comment at: test/clang-tidy/clang-tidy-mac-libcxx.cpp:11 +// Pretend clang is installed beside the mock library that we provided. +// RUN: echo '[{"directory":"%t","command":"%t/mock-libcxx/bin/clang++ -stdlib=libc++ -target x86_64-apple-darwin -

[PATCH] D54311: Add a test checking clang-tidy can find libc++ on Mac

ilya-biryukov created this revision. ilya-biryukov added reviewers: sammccall, arphaman. Herald added a reviewer: EricWF. Herald added a subscriber: christof. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D54311 Files: test/clang-tidy/Inputs/mock-libcxx/include/c++/v1/mock_vect