This revision was automatically updated to reflect the committed changes.
Closed by commit rL344736: [clangd] Names that are not spelled in source code
are reserved. (authored by ioeric, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://reviews.llvm.org/D5337
ioeric updated this revision to Diff 170068.
ioeric marked an inline comment as done.
ioeric added a comment.
- add isImplementationDetail helper
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D53374
Files:
clangd/AST.cpp
clangd/AST.h
clangd/Quality.cpp
clangd/Quality.h
sammccall accepted this revision.
sammccall added inline comments.
This revision is now accepted and ready to land.
Comment at: clangd/Quality.cpp:181
if (SemaCCResult.Declaration) {
+if (!isSpelledInSourceCode(SemaCCResult.Declaration))
+ ImplementationDetail = true;
ioeric added inline comments.
Comment at: clangd/Quality.cpp:182
if (auto *ID = SemaCCResult.Declaration->getIdentifier())
- ReservedName = ReservedName || isReserved(ID->getName());
+ ReservedName = ReservedName || isReserved(ID->getName()) ||
+
ioeric updated this revision to Diff 170046.
ioeric marked 3 inline comments as done.
ioeric added a comment.
- address comments
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D53374
Files:
clangd/AST.cpp
clangd/AST.h
clangd/Quality.cpp
clangd/Quality.h
clangd/index/In
sammccall added a comment.
Idea looks good, I think it needs some renames and index support.
Comment at: clangd/AST.h:33
+// `-DName=foo`, the spelling location will be "".
+bool SpelledInSourceCode(const Decl *D);
+
nit: should start with lowercase: `isSpe
ioeric created this revision.
ioeric added a reviewer: sammccall.
Herald added subscribers: cfe-commits, kadircet, arphaman, jkorous, MaskRay,
ilya-biryukov.
These are often not expected to be used directly e.g.
TEST_F(Fixture, X) {
^ // "Fixture_X_Test" expanded in the macro should be do
