sammccall accepted this revision.
sammccall added inline comments.
This revision is now accepted and ready to land.


================
Comment at: clangd/Quality.cpp:181
   if (SemaCCResult.Declaration) {
+    if (!isSpelledInSourceCode(SemaCCResult.Declaration))
+      ImplementationDetail = true;
----------------
We could consider putting this in a one-liner function in AST.h or so, in case 
we want to add more heuristics - so SymbolCollector and Quality remain 
consistent. Up to you.


Repository:
  rCTE Clang Tools Extra

https://reviews.llvm.org/D53374



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to