This revision was automatically updated to reflect the committed changes.
Closed by commit rL344117: [X86] Remove FeatureRTM from Skylake processor list
(authored by ctopper, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D53042?vs=168
lebedev.ri added inline comments.
Comment at: lib/Basic/Targets/X86.cpp:169
setFeatureEnabledImpl(Features, "mpx", true);
if (Kind != CK_SkylakeServer) // SKX inherits all SKL features, except SGX
setFeatureEnabledImpl(Features, "sgx", true);
thi
craig.topper accepted this revision.
craig.topper added a comment.
This revision is now accepted and ready to land.
LGTM
https://reviews.llvm.org/D53042
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/li
thiagomacieira updated this revision to Diff 168936.
thiagomacieira added a comment.
Added test update
https://reviews.llvm.org/D53042
Files:
lib/Basic/Targets/X86.cpp
test/Preprocessor/predefined-arch-macros.c
Index: test/Preprocessor/predefined-arch-macros.c
=
thiagomacieira added inline comments.
Comment at: lib/Basic/Targets/X86.cpp:169
setFeatureEnabledImpl(Features, "mpx", true);
if (Kind != CK_SkylakeServer) // SKX inherits all SKL features, except SGX
setFeatureEnabledImpl(Features, "sgx", true);
craig.topper requested changes to this revision.
craig.topper added a comment.
This revision now requires changes to proceed.
But there is definitely at least one test that needs to be updated.
@thiagomacieira, can update them or would you like me to?
Comment at: lib/Basic/Tar
craig.topper added inline comments.
Comment at: lib/Basic/Targets/X86.cpp:169
setFeatureEnabledImpl(Features, "mpx", true);
if (Kind != CK_SkylakeServer) // SKX inherits all SKL features, except SGX
setFeatureEnabledImpl(Features, "sgx", true);
l
lebedev.ri added inline comments.
Comment at: lib/Basic/Targets/X86.cpp:169
setFeatureEnabledImpl(Features, "mpx", true);
if (Kind != CK_SkylakeServer) // SKX inherits all SKL features, except SGX
setFeatureEnabledImpl(Features, "sgx", true);
> h
craig.topper accepted this revision.
craig.topper added a comment.
This revision is now accepted and ready to land.
LGTM
Repository:
rC Clang
https://reviews.llvm.org/D53042
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llv
thiagomacieira created this revision.
thiagomacieira added reviewers: erichkeane, craig.topper.
Herald added a subscriber: cfe-commits.
craig.topper retitled this revision from "Remove FeatureRTM from Skylake
processor list" to "[X86] Remove FeatureRTM from Skylake processor list".
There are a LO
10 matches
Mail list logo
