[PATCH] D52870: [NestedNameSpecifier] Add missing stream-specific dump methods

2018-10-04 Thread Stephen Kelly via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL343807: [NestedNameSpecifier] Add missing stream-specific dump methods (authored by steveire, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM https://reviews.llvm.org/D5287

[PATCH] D52870: [NestedNameSpecifier] Add missing stream-specific dump methods

2018-10-04 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Repository: rC Clang https://reviews.llvm.org/D52870 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.

[PATCH] D52870: [NestedNameSpecifier] Add missing stream-specific dump methods

2018-10-04 Thread Stephen Kelly via Phabricator via cfe-commits
steveire updated this revision to Diff 168338. steveire added a comment. Format Repository: rC Clang https://reviews.llvm.org/D52870 Files: include/clang/AST/NestedNameSpecifier.h lib/AST/NestedNameSpecifier.cpp Index: lib/AST/NestedNameSpecifier.cpp ===

[PATCH] D52870: [NestedNameSpecifier] Add missing stream-specific dump methods

2018-10-04 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman added inline comments. Comment at: lib/AST/NestedNameSpecifier.cpp:342 void NestedNameSpecifier::dump(const LangOptions &LO) const { + dump(llvm::errs(), LO); `LLVM_DUMP_METHOD` ? Comment at: lib/AST/NestedNameSpecifier.cpp:34

[PATCH] D52870: [NestedNameSpecifier] Add missing stream-specific dump methods

2018-10-04 Thread Stephen Kelly via Phabricator via cfe-commits
steveire created this revision. steveire added a reviewer: aaron.ballman. Herald added a subscriber: cfe-commits. Repository: rC Clang https://reviews.llvm.org/D52870 Files: include/clang/AST/NestedNameSpecifier.h lib/AST/NestedNameSpecifier.cpp Index: lib/AST/NestedNameSpecifier.cpp ===