[PATCH] D52870: [NestedNameSpecifier] Add missing stream-specific dump methods

[Aaron Ballman via Phabricator via cfe-commits]

aaron.ballman added inline comments.


================
Comment at: lib/AST/NestedNameSpecifier.cpp:342
 
 void NestedNameSpecifier::dump(const LangOptions &LO) const {
+  dump(llvm::errs(), LO);
----------------
`LLVM_DUMP_METHOD` ?


================
Comment at: lib/AST/NestedNameSpecifier.cpp:346
 
-LLVM_DUMP_METHOD void NestedNameSpecifier::dump() const {
+void NestedNameSpecifier::dump() const {
+  dump(llvm::errs());
----------------
`LLVM_DUMP_METHOD` ?


================
Comment at: lib/AST/NestedNameSpecifier.cpp:350
+
+void NestedNameSpecifier::dump(llvm::raw_ostream& OS) const
+{
----------------
`LLVM_DUMP_METHOD` ?


================
Comment at: lib/AST/NestedNameSpecifier.cpp:351
+void NestedNameSpecifier::dump(llvm::raw_ostream& OS) const
+{
   LangOptions LO;
----------------
Formatting is incorrect here.


================
Comment at: lib/AST/NestedNameSpecifier.cpp:356-357
+
+LLVM_DUMP_METHOD void NestedNameSpecifier::dump(llvm::raw_ostream& OS, const 
LangOptions &LO) const
+{
+  print(OS, PrintingPolicy(LO));
----------------
Same here.


Repository:
  rC Clang

https://reviews.llvm.org/D52870



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits