steveire marked an inline comment as done.
steveire added inline comments.
Comment at: clang-query/QueryParser.cpp:42
+End = Begin;
+return StringRef(Begin, 0);
+ }
aaron.ballman wrote:
> This is just returning an empty `StringRef`, isn't it? Might as we
This revision was automatically updated to reflect the committed changes.
Closed by commit rCTE343666: [clang-query] Add comment token handling (authored
by steveire, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D52752?vs=167848&id=168080#toc
Repository:
rCTE Clang Tools
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
LGTM aside from a minor nit.
Comment at: clang-query/QueryParser.cpp:42
+End = Begin;
+return StringRef(Begin, 0);
+ }
This is just re
steveire updated this revision to Diff 167848.
steveire added a comment.
Remove garbage
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D52752
Files:
clang-query/QueryParser.cpp
unittests/clang-query/QueryParserTest.cpp
Index: unittests/clang-query/QueryParserTest.cpp
=
steveire created this revision.
steveire added a reviewer: aaron.ballman.
Herald added subscribers: cfe-commits, mgorny.
It is possible to pass a file of commands to clang-query using the
command line option -f or --preload. Make it possible to write comments
in such files.
Repository:
rCTE C
