[PATCH] D52730: [analysis] ConversionChecker: handle floating point

2018-10-01 Thread Artem Dergachev via Phabricator via cfe-commits
NoQ added inline comments. Comment at: lib/StaticAnalyzer/Checkers/ConversionChecker.cpp:175 + + if (RepresentsUntilExp >= sizeof(unsigned long long)*8) { return false; Szelethus wrote: > Szelethus wrote: > > How about `AC.getSizeType(AC.UnsignedLongLongTy)

[PATCH] D52730: [analysis] ConversionChecker: handle floating point

2018-10-01 Thread Umann Kristóf via Phabricator via cfe-commits
Szelethus added a subscriber: whisperity. Szelethus added inline comments. Comment at: lib/StaticAnalyzer/Checkers/ConversionChecker.cpp:175 + + if (RepresentsUntilExp >= sizeof(unsigned long long)*8) { return false; Szelethus wrote: > How about `AC.getSize

[PATCH] D52730: [analysis] ConversionChecker: handle floating point

2018-10-01 Thread Umann Kristóf via Phabricator via cfe-commits
Szelethus added inline comments. Comment at: lib/StaticAnalyzer/Checkers/ConversionChecker.cpp:175 + + if (RepresentsUntilExp >= sizeof(unsigned long long)*8) { return false; How about `AC.getSizeType(AC.UnsignedLongLongTy))`? Comment at:

[PATCH] D52730: [analysis] ConversionChecker: handle floating point

2018-10-01 Thread Donát Nagy via Phabricator via cfe-commits
donat.nagy created this revision. donat.nagy added reviewers: NoQ, george.karpenkov, rnkovacs, baloghadamsoftware, mikhail.ramalho. Herald added subscribers: cfe-commits, Szelethus. Extend the alpha.core.Conversion checker to handle implicit converions where a too large integer value is converted