NoQ added inline comments.

================
Comment at: lib/StaticAnalyzer/Checkers/ConversionChecker.cpp:175
+
+  if (RepresentsUntilExp >= sizeof(unsigned long long)*8) {
     return false;
----------------
Szelethus wrote:
> Szelethus wrote:
> > How about `AC.getSizeType(AC.UnsignedLongLongTy))`?
> I'm actually not too sure about this. @whisperity?
Yeah, i suspect it's a host machine check (to prevent our own overflow on line 
189) rather than a target machine check.


Repository:
  rC Clang

https://reviews.llvm.org/D52730



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to